Fix 400 response attaching non-available volume

It's an error to attempt volume attachment before it's finished being
created (in OpenStack).  This problem wasn't noticed because volumes
were always created fast enough previously.  Fix this by examining the
volume status, and not attempting attachment until it's "available".

Also fix a bug when volume attachment fails, ``destroy()`` would leak
it.  This happens because it only deleted previously attached volumes.
Fix this by searching all volumes, and matching the server-id in it's
name - volumes always created this way.  If matched, include it in the
to-be-deleted list.

Lastly, do not kill the ``previous_responses`` cache upon
``OpenstackREST()`` init.  This makes debugging awful difficult since
the default behavior is to try and delete partially created resources.

Signed-off-by: Chris Evich <[email protected]>

Author: cevich

.test_openstack_TestDestroy.test_found.json

@@ -4,176 +4,128 @@
     "response": {
       "servers": [
         {
-          "id": "1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
+          "id": "deleteme",
           "name": "deleteme"
-        },
-        {
-          "id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a",
-          "name": "troublemaker"
         }
       ]
     },
-    "sequence_number": 5,
+    "sequence_number": 0,
     "status_code": 200
   },
   {
     "GET": "http://1.2.3.4/servers",
     "response": {
       "servers": [
         {
-          "id": "1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
+          "id": "deleteme",
           "name": "deleteme"
-        },
-        {
-          "id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a",
-          "name": "troublemaker"
         }
       ]
     },
     "sequence_number": 10,
     "status_code": 200
   },
   {
-    "GET": "http://1.2.3.4/servers/1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
+    "GET": "http://1.2.3.4/servers/deleteme",
     "response": {
       "server": {
         "OS-EXT-STS:power_state": 1,
         "OS-EXT-STS:vm_state": "active",
-        "addresses": {
-          "network_name": [
-            {
-              "OS-EXT-IPS-MAC:mac_addr": "fa:16:3e:1b:51:76",
-              "OS-EXT-IPS:type": "fixed",
-              "addr": "5.4.3.2",
-              "version": 4
-            },
+        "accessIPv4": "",
+        "accessIPv6": "",
+        "config_drive": "",
+        "flavor": {
+          "id": "3",
+          "links": [
             {
-              "OS-EXT-IPS-MAC:mac_addr": "fa:16:3e:1b:51:77",
-              "OS-EXT-IPS:type": "floating",
-              "addr": "4.5.6.7",
-              "version": 4
+              "href": "http://1.2.3.4/flavors/3",
+              "rel": "bookmark"
             }
           ]
         },
-        "id": "1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
+        "id": "deleteme",
         "name": "deleteme",
         "os-extended-volumes:volumes_attached": [
-            {"id": "4150770f-68b1-4ead-bce2-9f5a0eef8831"}
+          {
+            "id": "19d9b7f9-7d3d-4d56-aecd-6da28fa39f28"
+          }
         ],
+        "progress": 0,
         "status": "ACTIVE"
       }
     },
-    "sequence_number": 12,
+    "sequence_number": 20,
     "status_code": 200
   },
   {
-    "DELETE": "http://1.2.3.4/servers/1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
-    "sequence_number": 20,
-    "status_code": 204,
-    "response": null
+    "DELETE": "http://1.2.3.4/servers/deleteme"
   },
   {
     "GET": "http://1.2.3.4/servers",
     "response": {
       "servers": [
         {
-          "id": "295eb339-d94a-4a12-8c80-7a2b81d473d6",
-          "name": "deleteme"
-        },
-        {
-          "id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a",
-          "name": "troublemaker"
-        },
-        {
-          "id": "1d14de48-3ab0-4a0c-8c9f-65f00085d4ec",
+          "id": "deleteme",
           "name": "deleteme"
         }
       ]
     },
-    "sequence_number": 25,
+    "sequence_number": 30,
     "status_code": 200
   },
   {
     "GET": "http://1.2.3.4/servers",
     "response": {
-      "servers": [
-        {
-          "id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a",
-          "name": "troublemaker"
-        },
-        {
-          "id": "295eb339-d94a-4a12-8c80-7a2b81d473d6",
-          "name": "deleteme"
-        }
-      ]
+      "servers": []
     },
-    "sequence_number": 30,
+    "sequence_number": 40,
     "status_code": 200
   },
   {
-    "GET": "http://1.2.3.4/volumes/4150770f-68b1-4ead-bce2-9f5a0eef8831",
+    "GET": "http://1.2.3.4/volumes",
     "response": {
-      "volume": {
-        "attachments": [
-          {"id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a"}
-        ],
-        "id": "4150770f-68b1-4ead-bce2-9f5a0eef8831",
-        "size": 10,
-        "status": "in-use",
-        "name": "deleteme"
+      "volumes": [
+        {
+          "id": "19d9b7f9-7d3d-4d56-aecd-6da28fa39f28",
+          "name": "deleteme"
         }
+      ]
     },
-    "sequence_number": 46,
-    "status_code": 200
-  },
-  {
-    "DELETE": "http://1.2.3.4/servers/c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a/os-volume_attachments/4150770f-68b1-4ead-bce2-9f5a0eef8831",
     "sequence_number": 50,
-    "status_code": 204
-  },
-  {
-    "GET": "http://1.2.3.4/volumes/4150770f-68b1-4ead-bce2-9f5a0eef8831",
-    "response": {
-      "volume": {
-        "attachments": [
-          {"id": "c80f2e0a-09b7-4ad0-ac34-e40a5cfd418a"}
-        ],
-        "id": "4150770f-68b1-4ead-bce2-9f5a0eef8831",
-        "size": 10,
-        "status": "in-use",
-        "name": "deleteme"
-        }
-    },
-    "sequence_number": 54,
     "status_code": 200
   },
   {
-    "GET": "http://1.2.3.4/volumes/4150770f-68b1-4ead-bce2-9f5a0eef8831",
+    "GET": "http://1.2.3.4/volumes/19d9b7f9-7d3d-4d56-aecd-6da28fa39f28",
     "response": {
       "volume": {
         "attachments": [],
-        "id": "4150770f-68b1-4ead-bce2-9f5a0eef8831",
-        "size": 10,
+        "bootable": "false",
+        "consistencygroup_id": null,
+        "description": "Created for deleteme (deleteme)",
+        "id": "19d9b7f9-7d3d-4d56-aecd-6da28fa39f28",
+        "metadata": {
+          "readonly": "False"
+        },
+        "multiattach": false,
+        "name": "deleteme",
+        "size": 20,
         "status": "available",
-        "name": "deleteme"
-        }
+        "volume_type": null
+      }
     },
-    "sequence_number": 58,
+    "sequence_number": 130,
     "status_code": 200
   },
   {
-    "DELETE": "http://1.2.3.4/volumes/4150770f-68b1-4ead-bce2-9f5a0eef8831",
-    "sequence_number": 59,
-    "status_code": 204
+    "DELETE": "http://1.2.3.4/volumes/19d9b7f9-7d3d-4d56-aecd-6da28fa39f28"
   },
   {
     "GET": "http://1.2.3.4/volumes",
     "response": {
       "volumes": [
-        {"id": "47e8ff25-1465-49c7-a3c5-8c877425d973", "name": "newone"}
       ]
     },
-    "sequence_number": 60,
+    "sequence_number": 202,
     "status_code": 200
   }
 ]