Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing Tornado with modern async server/framework #381

Open
stefanv opened this issue Mar 22, 2024 · 0 comments
Open

Consider replacing Tornado with modern async server/framework #381

stefanv opened this issue Mar 22, 2024 · 0 comments
Labels

Comments

@stefanv
Copy link
Contributor

stefanv commented Mar 22, 2024

Motivation

  • Tornado is, nowadays, slower than some other frameworks.
  • We built numerous features ourselves that are, now, supported by frameworks; e.g., API docs & validation.

Options

  • FastAPI / starlette
  • aiohttp
  • uvicorn

aiohttp and uvicorn are fast, but both low level. FastAPI + starlette gives us approximate parity with what we have in our customized Tornado setup.

Strategy

Implement this on a branch first, to allow SkyPortal to try it out. This may introduce a significant amount of work for that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant