Validate HTTP version #2976
Open
Validate HTTP version #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertc2000
commented
Nov 28, 2024
| ASSERT(fpr(&mgr, buf, url, | ||
| "HEAD /a.txt HTTP/1.1\n\nGET /a.txt HTTP/1.1\n\n") == 2); | ||
| /*ASSERT(fpr(&mgr, buf, url, | ||
| "HEAD /a.txt HTTP/1.1\n\nGET /a.txt HTTP/1.1\n\n") == 2);*/ |
There was a problem hiding this comment.
I disabled this test because the HTTP reply from the 2nd request (GET /a.txt HTTP/1.1\n\n) appears to be truncated (missing first 6 characters, so it starts with '.1' instead of 'HTTP/1.1').
The issue was present before, but the tests weren't catching it and this latest patch, which adds a validation step in the HTTP request, catches it.
From what I'm reading in issue #2796, @scaprile correctly predicted Scenario 3: HEAD breaks the flow of pipelined requests. The test passes instead with any other request type rather than 'HEAD'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.