closing connection if a fragmented packet is received #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertc2000
force-pushed
the
ip-fragmentation
branch
from
a6dc0db to
f5c61c8
Compare
scaprile
approved these changes
Aug 30, 2023
Comment on lines
+728
to
+729
| if (pkt->ip->proto == 17) pkt->udp = (struct udp *) (pkt->ip + 1); | ||
| if (pkt->ip->proto == 6) pkt->tcp = (struct tcp *) (pkt->ip + 1); |
There was a problem hiding this comment.
We check here the protocol in order to be able to find and close the connection...
I guess there is no other way...
| static void fn(struct mg_connection *c, int ev, void *ev_data, void *fn_data) { | ||
| if (ev == MG_EV_ERROR) { | ||
| if (s_sent_fragment) { | ||
| ASSERT(strcmp((char*) ev_data, "Received fragmented packet") == 0); |
There was a problem hiding this comment.
ugly... but Sergey asked for this.
robertc2000
force-pushed
the
ip-fragmentation
branch
from
f5c61c8 to
f33e3a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.