Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in record 5500 #2517

Closed
clelange opened this issue Feb 22, 2019 · 4 comments · Fixed by #2522
Closed

Errors in record 5500 #2517

clelange opened this issue Feb 22, 2019 · 4 comments · Fixed by #2522
Assignees
@ArtemisLav
Milestone
CMS-Q4-Updates

Comments

@clelange
Copy link
Contributor

Hello,

While running the full 5500 example (levels 3 and 4 if you check the corresponding GitHub repo), I realised that there are a few bugs:
@tiborsimko tiborsimko added this to the CMS-Q4-Updates milestone Feb 28, 2019
@ArtemisLav ArtemisLav self-assigned this Mar 12, 2019
ArtemisLav added a commit to ArtemisLav/opendata.cern.ch that referenced this issue Mar 12, 2019
@ArtemisLav
recrods: fix record 5500
a435460 
* Fixes wrong link & adds a prominent link to record 5501 (closes cernopendata#2517)

Signed-off-by: Artemis Lavasa <[email protected]>
@ArtemisLav ArtemisLav mentioned this issue Mar 12, 2019
Merged
@ArtemisLav
Copy link
Member

#2522 addresses the first 2 points. Record 5501 is already published and has a DOI, so it is not possible to remove files from there.

@clelange
Copy link
Contributor Author

Thank you @ArtemisLav - regarding the superfluous files, and before closing the issue, what about adding a comment to 5501 stating which files are actually needed or not?

@ArtemisLav
Copy link
Member

@clelange Sure, if it's useful, I could add a note under 'How can you use these data?'. Could you please provide the text for the note?

@clelange
Copy link
Contributor Author

What about adding:

Mind that the following files are not needed to produce the plot but are only the products of intermittent processing steps:

- DY101Jets12.root
- DY50Mag12.root
- DYTo2mu12.root
- TTJets11.root
- TTJets12.root

ArtemisLav added a commit to ArtemisLav/opendata.cern.ch that referenced this issue Mar 13, 2019
@ArtemisLav
recrods: fix records 5500 and 5501
01a4ae0 
* Fixes wrong link & adds a prominent link to record 5500
* Adds a note about files in 5501 (closes cernopendata#2517)

Signed-off-by: Artemis Lavasa <[email protected]>
tiborsimko pushed a commit to ArtemisLav/opendata.cern.ch that referenced this issue Mar 15, 2019
@ArtemisLav @tiborsimko
records: fix records 5500 and 5501
603b4f0 
* Fixes wrong link & adds a prominent link to record 5500
* Adds a note about files in 5501 (closes cernopendata#2517)

Signed-off-by: Artemis Lavasa <[email protected]>
@ghost ghost removed the Status: ready for work label Mar 15, 2019
@clelange clelange mentioned this issue Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemisLav ArtemisLav

Labels
None yet
Projects
None yet
Milestone
CMS-Q4-Updates
Development

Successfully merging a pull request may close this issue.

recrods: fix records 5500 and 5501 ArtemisLav/opendata.cern.ch
3 participants
@tiborsimko @clelange @ArtemisLav