add a hostNetwork setting to the Driver and ControllerPlugin Specs #194
+76
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated to address the port collisions that @rohan47 observed in testing. I have built an image and pushed it to quay: $ docker pull quay.io/madam/ceph-csi-operator:host-net`or: $ podman pull quay.io/madam/ceph-csi-operator:host-net |
Madhu-1
reviewed
Feb 6, 2025
rohan47
reviewed
Feb 6, 2025
obnoxxx
force-pushed
the
host-network
branch
2 times, most recently
from
6be915c to
1eb0b25
Compare
|
@Madhu-1 : updated with names |
|
CI failures seem to be mostly due to problems with |
obnoxxx
force-pushed
the
host-network
branch
2 times, most recently
from
8fb941f to
12052b9
Compare
|
Verified the changes. The controller plugin pods are coming up with hostNetwork and there is no port collision |
@rohan47 can you please share the |
|
According to @rohan47, even with the latest build, port collision is happening between rbd and cephfs controller plugin pods. I am going to update with a fix soon. |
|
Updated to try and set different ports for rbd and cephfs drivers. But I have some typo and could not even get it to compile ... |
|
updated , and now it builds. also pushed new images to quay. |
|
Tested the latest changes On the node |
Madhu-1
requested changes
Feb 10, 2025
This bool setting can be added to the controllerPlugin section of the Driver Spec. It will be propagated to all controller plugin pods. This implements the following design: https://github.com/ceph/ceph-csi-operator/blob/main/docs/design/hostNetwork.md Signed-off-by: Michael Adam <[email protected]>
obnoxxx
force-pushed
the
host-network
branch
4 times, most recently
from
8e96823 to
c199901
Compare
Madhu-1
requested changes
Feb 10, 2025
obnoxxx
force-pushed
the
host-network
branch
from
82bae67 to
555c3f2
Compare
Madhu-1
reviewed
Feb 10, 2025
obnoxxx
force-pushed
the
host-network
branch
from
742d96b to
affb65e
Compare
obnoxxx
force-pushed
the
host-network
branch
from
affb65e to
ca29371
Compare
|
updated one more time with build fix. image pushed to quay. |
obnoxxx
force-pushed
the
host-network
branch
from
ca29371 to
2ac34f4
Compare
Madhu-1
reviewed
Feb 10, 2025
Madhu-1
previously approved these changes
Feb 10, 2025
Madhu-1
reviewed
Feb 10, 2025
obnoxxx
force-pushed
the
host-network
branch
from
0afa568 to
8bb9c0b
Compare
obnoxxx
force-pushed
the
host-network
branch
from
b6bc002 to
f527a6e
Compare
obnoxxx
force-pushed
the
host-network
branch
from
f527a6e to
cc75fb1
Compare
|
updated one more time to fix build/vet error. image updated on quay. |
|
Tested the latest changes On Node |
Madhu-1
reviewed
Feb 10, 2025
obnoxxx
force-pushed
the
host-network
branch
from
cc75fb1 to
63d7e12
Compare
Usubg host network produces port collisions. So we use different ports for controller plugin deployments and node plugin deamonsets to avoid collisions. We also make sure that rbd and cephfs drivers don't collide Signed-off-by: Michael Adam <[email protected]>
obnoxxx
force-pushed
the
host-network
branch
from
63d7e12 to
bca85a9
Compare
Madhu-1
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bool setting can be added to the controllerPlugin section of the Driver Spec.
It will be propagated to all controller plugin pods.
This implements the following design:
https://github.com/ceph/ceph-csi-operator/blob/main/docs/design/hostNetwork.md
see issue #157 for background and context.
Describe what this PR does
This work in progress is a draft PR for the implementation of host Networking for controller plugin pods as described in https://github.com/ceph/ceph-csi-operator/blob/main/docs/design/hostNetwork.md
Is there anything that requires special attention
This needs thorough testing.
Is the change backward compatible?
should be but this needs testing.
Are there concerns around backward compatibility?
none right now
For example:
Related issues
Fixes: #157
Future concerns
none.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.