Update DriftChamber construct

Author: myliu

Detector/DetDriftChamber/src/driftchamber/DriftChamber.cpp

@@ -171,7 +171,6 @@ static dd4hep::Ref_t create_detector(dd4hep::Detector& theDetector,
             offset = 0.5 * cell_phi;
         }
         double epsilon = sign_eps*std::atan(rmid_zZero * std::tan(alpha / 2.0) / chamber_half_length);
-        //double alpha0 = 2*std::asin(chamber_length * std::tan(epsilon)/(2*rmid_zEnd));
 
         segmentationDC->setGeomParams(chamber_id, layer_id, cell_phi, rmid_zEnd , epsilon, offset);
         segmentationDC->setWiresInLayer(chamber_id, layer_id, nCell);
@@ -241,8 +240,6 @@ static dd4hep::Ref_t create_detector(dd4hep::Detector& theDetector,
         }//end of loop over cell
         dd4hep::Transform3D transform_layer(dd4hep::Rotation3D(),
                 dd4hep::Position(0,0,0));
-        dd4hep::PlacedVolume layer_phy = det_chamber_vol.placeVolume(layer_vol,transform_layer);
-        layer_phy.addPhysVolID("layer", layer_id);
     }//end of loop over layers
 
 

Detector/DetSegmentation/include/DetSegmentation/GridDriftChamber.h

@@ -34,7 +34,6 @@ typedef struct CID
  {
    int chamberID;
    int layerID;
-//   CID(){}
    CID(int i, int j): chamberID(i),layerID(j){}
    // the operator < defines the operation used in map
    friend bool operator < (const CID &c1, const CID &c2);
@@ -176,7 +175,6 @@ class GridDriftChamber : public Segmentation {
  }
 
   double m_cellSize;
-//  double m_epsilon0;
   double m_detectorLength;
   double m_layer_width;
   double m_DC_rbegin;

Detector/DetSegmentation/src/GridDriftChamber.cpp

@@ -329,6 +329,5 @@ double GridDriftChamber::Distance(const CellID& cID, const TVector3& pointIn, co
     return distance;
 }
 
-
 }
 }

Digitisers/DCHDigi/src/DCHDigiAlg.cpp

@@ -167,9 +167,6 @@ StatusCode DCHDigiAlg::execute()
       TVector3 Wend  (0,0,0);
       m_segmentation->cellposition(wcellid, Wstart, Wend);
       float dd4hep_mm = dd4hep::mm;
-      //std::cout<<"dd4hep_mm="<<dd4hep_mm<<std::endl;
-      //    Wstart =(1/dd4hep_mm)* Wstart;// from DD4HEP cm to mm
-      //    Wend   =(1/dd4hep_mm)* Wend  ;
       if(m_debug) std::cout<<"DCHDigi wcellid ="<<wcellid<< ",chamber="<<chamber<<",layer="<<layer<<",cellID="<<cellID<<",s_x="<<Wstart.x()<<",s_y="<<Wstart.y()<<",s_z="<<Wstart.z()<<",E_x="<<Wend.x()<<",E_y="<<Wend.y()<<",E_z="<<Wend.z()<<std::endl;
 
       TVector3  denominator = (Wend-Wstart) ;

Digitisers/DCHDigi/src/DCHDigiAlg.h

@@ -96,7 +96,6 @@ class DCHDigiAlg : public GaudiAlgorithm
   Gaudi::Property<bool>  m_debug{ this, "debug", false};
   Gaudi::Property<double>  m_wireEff{ this, "wireEff", 1.0};
 
-
   // Input collections
   DataHandle<edm4hep::SimTrackerHitCollection> r_SimDCHCol{"DriftChamberHitsCollection", Gaudi::DataHandle::Reader, this};
   // Output collections