Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Allow redirects for proxy #1229

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

GrantAnt
Copy link
Contributor

In the current implementation, proxies are offered but not usable.
In case requests library has proxy options set, allow_redirect needs to be set to true.

@google-cla
Copy link

google-cla bot commented Sep 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@GrantAnt
Copy link
Contributor Author

@lzchen Build Job for py39 failed. It seems not be connected to my code changes and last week the build was working on master.
Just restart build tool?

@lzchen
Copy link
Contributor

lzchen commented Sep 28, 2023

@GrantAnt

Looks like build is failing for lint.

@GrantAnt
Copy link
Contributor Author

@lzchen which linter is executed? Can I run it locally?

@lzchen
Copy link
Contributor

lzchen commented Sep 28, 2023

@GrantAnt

image

Looks like it's flake8. You can see the lint steps here: https://github.com/census-instrumentation/opencensus-python/blob/master/tox.ini#L68

@GrantAnt
Copy link
Contributor Author

@lzchen How could I be so blind. Thank you so much :) Whitespaces are resolved now

@lzchen lzchen merged commit 5eed408 into census-instrumentation:master Sep 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants