Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 2333df4

Browse files
authored
Update the message names for Config RPC. (#93)
* Update the message names for Config RPC. * Update message order and name. * Rename to UpdatedLibraryConfig. * Update gen-go files.
1 parent 3234379 commit 2333df4

File tree

2 files changed

+87
-85
lines changed

2 files changed

+87
-85
lines changed

gen-go/agent/trace/v1/trace_service.pb.go

Lines changed: 83 additions & 81 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

opencensus/proto/agent/trace/v1/trace_service.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ option go_package = "github.com/census-instrumentation/opencensus-proto/gen-go/a
3232
service TraceService {
3333
// After initialization, this RPC must be kept alive for the
3434
// entire life of the application. The agent pushes configs
35-
// down to applications via a stream of requests.
36-
rpc Config(stream ConfigTraceServiceResponse) returns (stream ConfigTraceServiceRequest) {}
35+
// down to applications via a stream.
36+
rpc Config(stream CurrentLibraryConfig) returns (stream UpdatedLibraryConfig) {}
3737

3838
// Allows applications to send spans to the agent.
3939
// For performance reasons, it is recommended to keep this RPC
4040
// alive for the entire life of the application.
4141
rpc Export(stream ExportTraceServiceRequest) returns (stream ExportTraceServiceResponse) {}
4242
}
4343

44-
message ConfigTraceServiceRequest {
44+
message CurrentLibraryConfig {
4545
// Identifier data effectively is a structured metadata.
4646
// This is required only in the first message on the stream.
4747
opencensus.proto.agent.common.v1.Node node = 1;
@@ -50,7 +50,7 @@ message ConfigTraceServiceRequest {
5050
opencensus.proto.trace.v1.TraceConfig config = 2;
5151
}
5252

53-
message ConfigTraceServiceResponse {
53+
message UpdatedLibraryConfig {
5454
// Requested updated configuration.
5555
opencensus.proto.trace.v1.TraceConfig config = 2;
5656
}

0 commit comments

Comments
 (0)