From ec8706ad08d1625d29201e3bdbc07650e072276e Mon Sep 17 00:00:00 2001 From: Omar Elgabry Date: Mon, 7 Sep 2020 15:48:43 -0400 Subject: [PATCH] Convert 500 http status code to trace.status --- plugin/ochttp/trace.go | 2 ++ plugin/ochttp/trace_test.go | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/plugin/ochttp/trace.go b/plugin/ochttp/trace.go index ed3a5db56..6e4ec717a 100644 --- a/plugin/ochttp/trace.go +++ b/plugin/ochttp/trace.go @@ -198,6 +198,8 @@ func TraceStatus(httpStatusCode int, statusLine string) trace.Status { code = trace.StatusCodeUnauthenticated case http.StatusTooManyRequests: code = trace.StatusCodeResourceExhausted + case http.StatusInternalServerError: + code = trace.StatusCodeInternal case http.StatusNotImplemented: code = trace.StatusCodeUnimplemented case http.StatusServiceUnavailable: diff --git a/plugin/ochttp/trace_test.go b/plugin/ochttp/trace_test.go index 615c271eb..5695c9769 100644 --- a/plugin/ochttp/trace_test.go +++ b/plugin/ochttp/trace_test.go @@ -667,7 +667,7 @@ func TestStatusUnitTest(t *testing.T) { {200, trace.Status{Code: trace.StatusCodeOK, Message: `OK`}}, {204, trace.Status{Code: trace.StatusCodeOK, Message: `OK`}}, {100, trace.Status{Code: trace.StatusCodeUnknown, Message: `UNKNOWN`}}, - {500, trace.Status{Code: trace.StatusCodeUnknown, Message: `UNKNOWN`}}, + {500, trace.Status{Code: trace.StatusCodeInternal, Message: `INTERNAL`}}, {400, trace.Status{Code: trace.StatusCodeInvalidArgument, Message: `INVALID_ARGUMENT`}}, {422, trace.Status{Code: trace.StatusCodeInvalidArgument, Message: `INVALID_ARGUMENT`}}, {499, trace.Status{Code: trace.StatusCodeCancelled, Message: `CANCELLED`}},