You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't ready, more of a prototype, I thought I'd open it since the idea of the record_module is what is important to get right for moving forward with configurable stat recording.
Certainly would be nice to not have to do the ets lookup if using the collector workers, but haven't thought of a way to do that except more codegen :(
@deadtrickster yea, two things. One is to have recordings just sent as a message to a process that handles the view updating, instead of updating the views inline of the process doing the recording. This should be optional, people will have different needs and not all will necessarily benefit from not doing view updates in the same process, so it also makes how the recording is done configurable.
Second idea? It is just making it configurable how a measure is recorded and adding an option to send a message for a recorded measure instead of updating the views in process.
ah, ok. it's just how you started "...two things... One is..." and I didn't locate second :-)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't ready, more of a prototype, I thought I'd open it since the idea of the
record_module
is what is important to get right for moving forward with configurable stat recording.