Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Merge metrics tags before passing them to the handler #138

Open
hauleth opened this issue Feb 13, 2019 · 1 comment
Open

Merge metrics tags before passing them to the handler #138

hauleth opened this issue Feb 13, 2019 · 1 comment

Comments

@hauleth
Copy link
Contributor

hauleth commented Feb 13, 2019

Currently almost all metric handlers need to do something like:

maps:merge(CTags, maps:from_list(lists:zip(Tags, TagsV)))

Which is little bit PITA. What I am proposing is to do it for them in the oc_stats:export/0 and return data with above "merging" function already done. This should reduce hurdle in defining metrics handlers and should unbound them from the internal storage of data in the application.

@hauleth
Copy link
Contributor Author

hauleth commented Feb 13, 2019

Alternatively use opencensus_service and provide list of tag names and list of tag values and skip CTags, just split them before and join it with Tags and TagsV beforehand.

@tpitale tpitale mentioned this issue Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant