Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Reporter create new ets tables #134

Open
tsloughter opened this issue Feb 9, 2019 · 2 comments
Open

Reporter create new ets tables #134

tsloughter opened this issue Feb 9, 2019 · 2 comments

Comments

@tsloughter
Copy link
Member

I'm wondering if we shouldn't be passing the ets table to reporters instead of a list of every element and create a new table instead of deleting all the objects.

Creating ets tables is cheap and it should save on memory and gc'ing to do this.

We really need some benchmarks to keep a baseline..

@hauleth
Copy link
Contributor

hauleth commented Feb 11, 2019

Question is how it will work with many reporters. Which one will be responsible for removing old table. I would keep API as is because it is simpler, and I do not believe that this will improve the performance by noticeable factor.

@tsloughter
Copy link
Member Author

None of the reporters would be, it would work the same as today, the central reporting process does the deleting. It just happens when the reporter handler is done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants