This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
CMake stackdriver enhancements #447
Open
alichnewsky
wants to merge
12
commits into
census-instrumentation:master
Choose a base branch
from
alichnewsky:cmake-stackdriver-enhancements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CMake stackdriver enhancements #447
alichnewsky
wants to merge
12
commits into
census-instrumentation:master
from
alichnewsky:cmake-stackdriver-enhancements
Commits on Jun 19, 2020
-
enhanced CMake support ( work in progress )
- support for package export and instal - opencensus_lib() now has a HDRS section just like Bazel. - opencensus_lib() allows declaration of headers in subdirectories, and installs them in proper directory - still issues with segregating public and private headers ( HDRS of non PUBLIC opencenus_lib ) ( it looks like customer can write code that includes internal files ) - still issues linking private static libraries together into bigger public ones. ( as Bazel does ) - attempt at allowing build as shared libraries - added helper code to request no undefined symbols in shared libraries. - attempt failed due to circular dependencies ( opencensus_trace and opencensus_context ). Until those are fixed, only static libs will work. - outlined many missing dependencies declarations, only fixed in CMake for now. ideally similar changes would be done to Bazel build, and Bazel would allow to build shared libs as well... - stackdriver / googleapis / google-cloud-cpp changed recently, does not export monitoring/logging and cloud trace/tracing libs. - attempt at building with FetchContent if and only if no existing package has been found. same ideas as using shared libraries : - reuse and to link ability into programs that may already use some of the same deps. - third party ( opencensus-cpp ) should not require significant alterations in consuming client build system ( hence CMake ) and strategy ( - linux-specifc example : using stackdriver exporter on Google Cloud Engine - parse /proc/meminfo and /proc/vmstat to stackdriver - rely via FetchContent on third party software - cpr ( to implement succintly access go GCE instance metadata server ) - re2 ( to brace against variable level of support/correctness in implementation of <regex> with old GCC versions ) - not yet verified on anything but CentOS 7 - in particular no effort has been yet made so that CI via travis or appveyor actually works. As such, not ready to merge
Configuration menu - View commit details
-
Copy full SHA for 5360131 - Browse repository at this point
Copy the full SHA 5360131View commit details -
Configuration menu - View commit details
-
Copy full SHA for 618a630 - Browse repository at this point
Copy the full SHA 618a630View commit details -
Configuration menu - View commit details
-
Copy full SHA for abb9edc - Browse repository at this point
Copy the full SHA abb9edcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1af7a6 - Browse repository at this point
Copy the full SHA b1af7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d21434d - Browse repository at this point
Copy the full SHA d21434dView commit details
Commits on Jun 20, 2020
-
CMake: stackdriver exporter build only behind an option. does a find_…
…package() on gRPC and googleapis. No FetchContent yet
Configuration menu - View commit details
-
Copy full SHA for 9262d39 - Browse repository at this point
Copy the full SHA 9262d39View commit details -
make protobuf/grpc/stackdriver dependent target contingent to BUILD_S…
…TACKDRIVER_EXPORTER CMake option
Configuration menu - View commit details
-
Copy full SHA for 21e7a6b - Browse repository at this point
Copy the full SHA 21e7a6bView commit details -
Fix travis-ci build : abseil as FetchContent means linking rule needs…
… change, fix newest example
Configuration menu - View commit details
-
Copy full SHA for 1818f72 - Browse repository at this point
Copy the full SHA 1818f72View commit details -
removed re2 as dependency for the new memory example, as I can\'t get…
… it to pass its own unit tests when used with FetchContent ...
Configuration menu - View commit details
-
Copy full SHA for 357b50b - Browse repository at this point
Copy the full SHA 357b50bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7221529 - Browse repository at this point
Copy the full SHA 7221529View commit details -
finally manually assembled the right versions of buildifier,clang-for…
…mat and cmake-format manually as docker-format Dockerfile is obsolete. format check should match travis one
Configuration menu - View commit details
-
Copy full SHA for 8675d05 - Browse repository at this point
Copy the full SHA 8675d05View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1fb529 - Browse repository at this point
Copy the full SHA c1fb529View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.