Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add support for StrictSpans mode in Tracing #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 28, 2019

  1. Add support for StrictSpans mode in Tracing

    Goal: StrictSpans mode is meant to enforce the invariant that a parent span cannot
    end while it has children running. If a parent span ends with active children, it is held open
    and its end is triggered when the last child ends. This works even with a chain of spans, the last child
    can trigger all parents up to the root to end.
    
    Details:
    1. Switch running_span_store_impl to key its map on SpanId instead of the pointer
    2. Add FindSpanById method on RunningSpanStoreImpl
    3. Add reference count called active_child_count_ on SpanImpl to keep track of active children
    4. Add logic at span start and end time to update the reference count on parents,
    5. Add tests
    Jack Ferris committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    3619b38 View commit details
    Browse the repository at this point in the history