Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Can kDelta views be registered for export #456

Open
zhongchun opened this issue Jan 28, 2021 · 1 comment
Open

Can kDelta views be registered for export #456

zhongchun opened this issue Jan 28, 2021 · 1 comment

Comments

@zhongchun
Copy link

In the view_descriptor.cc, we can see like this:

void ViewDescriptor::RegisterForExport() const {
  if (aggregation_window_.type() == AggregationWindow::Type::kCumulative) {
    StatsExporterImpl::Get()->AddView(*this);
  } else {
    std::cerr << "Only cumulative views may be registered for export.\n";
  }
}

Only cumulative views may be registered for export.
I modify this and find kDelta views can be registered for export and work well.
So i am a little confused, why opencensus don't support kDelta views to report.

@bubcool86
Copy link

In the view_descriptor.cc, we can see like this:

void ViewDescriptor::RegisterForExport() const {
  if (aggregation_window_.type() == AggregationWindow::Type::kCumulative) {
    StatsExporterImpl::Get()->AddView(*this);
  } else {
    std::cerr << "Only cumulative views may be registered for export.\n";
  }
}

Only cumulative views may be registered for export.
I modify this and find kDelta views can be registered for export and work well.
So i am a little confused, why opencensus don't support kDelta views to report.#456 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants