Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

trace, metrics: add Resource #17

Closed
songy23 opened this issue Sep 25, 2018 · 1 comment
Closed

trace, metrics: add Resource #17

songy23 opened this issue Sep 25, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@songy23
Copy link
Contributor

songy23 commented Sep 25, 2018

Currently Node.Attributes is an empty map:

opencensus-go-exporter-ocagent/nodeinfo.go

Line 39 in 00af367

Attributes: make(map[string]string),

We should add resource type and resource labels to the attribute map, once we have an agreement on census-instrumentation/opencensus-specs#162.
@songy23 songy23 added the enhancement New feature or request label Sep 25, 2018
@odeke-em
Copy link
Contributor

odeke-em commented Dec 9, 2018

@songy23 thanks for filing this issue!

So resource specs have since changed. I'll send a PR right now.

@odeke-em odeke-em changed the title attributes: Set resource type and labels. trace, metrics: add Resource Dec 9, 2018
odeke-em added a commit that referenced this issue Dec 9, 2018
@odeke-em
trace, metrics: add Resource to every initial message
7ef1421 
Following suit with the protocol, send a Resource as
the initial message since each application using ocagent
will create a single resource, just like we do with Node.

Fixes #17
odeke-em added a commit that referenced this issue Dec 9, 2018
@odeke-em
trace, metrics: add Resource to every initial message
060bba9 
Following suit with the protocol, send a Resource as
the initial message since each application using ocagent
will create a single resource, just like we do with Node.

Fixes #17
@odeke-em odeke-em mentioned this issue Dec 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odeke-em @songy23