Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input: line breaks #49

Open
cengels opened this issue Dec 19, 2020 · 0 comments
Open

Search input: line breaks #49

cengels opened this issue Dec 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working text area The issue concerns the text area

Comments

@cengels
Copy link
Owner

cengels commented Dec 19, 2020

The search currently does not support matches across multiple text blocks (i.e. paragraphs).

This seems to be an issue with Qt/QML first and foremost, as calling QTextDocment::find() with a regex containing \s, \u2029, \r or \n does not result in matches being found. It's quite possible that Qt/QML escapes the backslashes before passing them on to FormattableTextArea, which would explain why they're not working, but it's also possible there is another problem at work.

The TextHighlighter also currently does not support highlighting across multiple blocks, but that part at least is easy to implement. But before it can be implemented, QTextDocument::find() needs to return the right ranges.

@cengels cengels added bug Something isn't working text area The issue concerns the text area labels Dec 19, 2020
@cengels cengels self-assigned this Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text area The issue concerns the text area
Projects
None yet
Development

No branches or pull requests

1 participant