Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract computeRoot to a separate method #261

Open
rach-id opened this issue Jun 20, 2024 · 1 comment
Open

extract computeRoot to a separate method #261

rach-id opened this issue Jun 20, 2024 · 1 comment

Comments

@rach-id
Copy link
Member

rach-id commented Jun 20, 2024 

          I think this was simpler because `computeRoot` also operates on a few vars inside of the scope of the wrapping method (e.g. `subtreeRoots`). I think this was an optimization wrt to the recursive calls. I would merge as is but if benchmarks and readability improve or stay the same, I would not mind Evan's suggestion in a followup PR.

Originally posted by @liamsi in #260 (comment)
@rach-id rach-id mentioned this issue Jun 20, 2024
Merged
@rach-id
Copy link
Member Author

rach-id commented Jun 21, 2024

Also this: #260 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id