Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: document nmt proof format #248

Open
Tracked by #1835
, #2287
...
preston-evans98 opened this issue Feb 1, 2023 · 1 comment
Open
Tracked by #1835
, #2287
...

Feature Request: document nmt proof format #248

preston-evans98 opened this issue Feb 1, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@preston-evans98
Copy link
Contributor

Overview

Celestia-node now supports retrieving shares with proofs of inclusion 🎉.

Unfortunately, the format of the returned merkle proof doesn't seem to be documented anywhere, which makes it difficult to verify. I'd suggest adding documentation (maybe here) explaining the format of the proof (is the array of siblings generated by an inorder traversal? preorder? postorder?) and demonstrating how to verify it using the go implementation of the nmt.
@evan-forbes
Copy link
Member

related to celestiaorg/celestia-app#1296

@renaynay renaynay mentioned this issue Mar 2, 2023
Closed
@ramin ramin added the documentation Improvements or additions to documentation label Dec 18, 2023
@ramin ramin mentioned this issue Mar 1, 2024
Open
8 tasks
@ramin ramin transferred this issue from celestiaorg/celestia-node Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramin @preston-evans98 @evan-forbes