Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github workflow for proto-gen #224

Open
rootulp opened this issue Jul 18, 2023 · 1 comment
Open

Github workflow for proto-gen #224

rootulp opened this issue Jul 18, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 18, 2023

#220 added Proto definitions to this repo. We should add a Github workflow that verifies the checked-in generated Proto files match what is expected if Proto is used to generated them. In other words, a CI workflow to catch if a maintainer has updated a *.proto file without also committing the updated generated *.pb.go file.

Workflows in celestia-app may be used for inspiration: https://github.com/celestiaorg/celestia-app/blob/6b2ad5e9f45cef8d734b2062b9f2158ed6c15f96/.github/workflows/protobuf.yml
@rootulp rootulp added the good first issue Good for newcomers label Jul 18, 2023
@Harsh-Daga
Copy link

Hey @rootulp ,
I would like to work on this issue. Could you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @Harsh-Daga