Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof struct is missing a function for range verification #154

Open
andrijamitrovic23 opened this issue Mar 23, 2023 · 0 comments
Open

Proof struct is missing a function for range verification #154

andrijamitrovic23 opened this issue Mar 23, 2023 · 0 comments
Labels
audit Issue uncovered during Informal audit enhancement New feature or request

Comments

@andrijamitrovic23
Copy link
Collaborator

Proof struct does not have a function for verifying a range of leaves that do not have to belong to the same namespace.

In the nmt.go there is a function ProveRange that does not depend on namespaceID and builds a proof for a given range. However, there is no its Verify- inverse function in proof.go. All verify functions (VerifyNamespace and VerifyInclusion) in proof.go depend on the namespaceID.

Function verifyLeafHashes could be used for proving a range of leaves that do not have to belong to the same namespace if its parameter verifyCompleteness is set to false (then its parameter nID would not be used, so it could be nil). This functions is used for internal purposes (called from VerifyNamespace and VerifyInclusion), so it could be as a called from the new function for verifying proof for a given range of leaves.

@andrijamitrovic23 andrijamitrovic23 added the enhancement New feature or request label Mar 23, 2023
@rootulp rootulp added the audit Issue uncovered during Informal audit label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Issue uncovered during Informal audit enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants