Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(state/core_access): remove defaultSignerAccount and defaultSignerAddress in favor and use app.ClientTx instead #3515

Open
vgonkivs opened this issue Jun 20, 2024 · 2 comments
Open

improvement(state/core_access): remove defaultSignerAccount and defaultSignerAddress in favor and use app.ClientTx instead #3515

vgonkivs opened this issue Jun 20, 2024 · 2 comments
Labels
area:state Related to fetching state and state execution good first issue Good for newcomers

Comments

@vgonkivs
Copy link
Member

We can get rid of these two fields inside core_access and ru-use clientTx. Since the node's version of the app contains a small bug in handling DefaultAccountAddress(), it should be done after celestiaorg/celestia-app#3597 is included in app release.
@vgonkivs vgonkivs added good first issue Good for newcomers area:state Related to fetching state and state execution labels Jun 20, 2024
@MukulKolpe
Copy link

Hey @vgonkivs, can I work on this issue?

@vgonkivs
Copy link
Member Author

Hello, @MukulKolpe. These changes haven't been released yet. Also this issue is blocked by #3349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:state Related to fetching state and state execution good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vgonkivs @MukulKolpe