Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shwap hardening and optimizations tracking issue #3513

Open
1 of 21 tasks
walldiss opened this issue Jun 19, 2024 · 0 comments
Open
1 of 21 tasks

Shwap hardening and optimizations tracking issue #3513

walldiss opened this issue Jun 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request shwap

Comments

@walldiss
Copy link
Member

walldiss commented Jun 19, 2024

Implementation ideas

This issue will collect small improvements that remain after merging features to the shwap. Most have low priority, while others are planned for subsequent PRs and mentioned here to keep them tracked.

ODS file:

  • rename square to quadrant. Planned for Q1Q4 file PR
  • readODS benchmarking. Need to find optimal size for buffer used to read full ODS. Compare buffered read vs reading allocating single array for full ODS. @Wondertan
  • computeAxisHalf: Add more comment on actual algo(selection of opposite axes, usage reconstructSome, etc). Support it with visual diagram of computed axis.
  • fill ods field with data from eds. Planned for improving memory alloc in ODS file PR
  • codec should be removed. Planned after support for reconstructSome is added to rsmt2d.
  • header de/serialization funcs of should be fuzzed.

Q1Q4:

  • cache proofs on shrex recompute eds and use them to populate cache file. It will make proofs available in recent cache
  • Add option to AxisHalf method of Accessor to be able to read Q4 on file store

Store:

  • Storage should use eds.Accessor as input for Put().
  • Add support for reducing of Q1Q4file to ODSfile, when they move outside of sampling window.
  • Disallow serving samples outside of sampling window. Can be done by implementing Prunned AccessorGetter inside prunner pkg. Wrapper over AccessorGetter, that will wrap every Accessor with one, that do not allow getting samples from archival heights.

Misc:

Spec:

  • Define NamespaceData container and id
  • Proof-only mode for RowNamespaceData, NamespaceData, maybe Sample?
  • Define protocol IDs for bitswap composition
  • [ } Add shrex as composition
@walldiss walldiss added the enhancement New feature or request label Jun 19, 2024
@walldiss walldiss added the shwap label Jun 19, 2024
@Wondertan Wondertan changed the title Shwap hardening tracking issue Shwap hardening and optimizations tracking issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shwap
Projects
None yet
Development

No branches or pull requests

2 participants