Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(share/pruner): make pruner init to start from 0 #3474

Open
walldiss opened this issue Jun 6, 2024 · 0 comments
Open

refactor(share/pruner): make pruner init to start from 0 #3474

walldiss opened this issue Jun 6, 2024 · 0 comments
Labels
area:storage good first issue Good for newcomers

Comments

@walldiss
Copy link
Member

walldiss commented Jun 6, 2024

Implementation ideas

Pruner starts with initial checkpoint with height 1, but still needs to prune that height on first run. It is managed by

if lastPruned.Height() == 1 {
		headers = append([]*header.ExtendedHeader{lastPruned}, headers...)
	}

Rework initial checkpoint and logic for first run to use 0 height at init.
@walldiss walldiss added the enhancement New feature or request label Jun 6, 2024
@renaynay renaynay added good first issue Good for newcomers area:storage and removed enhancement New feature or request labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:storage good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@walldiss @renaynay