blob: Check max blob size and return err if exceeds

[renaynay]

Blocked on core/app (cc @rootulp)

[rootulp]

See celestiaorg/celestia-app#2108 and celestiaorg/celestia-app#2156

[rootulp]

We're considering improving the behavior of CheckTx in celestia-app by rejecting blobs that are too large (see celestiaorg/celestia-app#2156). Once that is implemented, I don't think it will be necessary for celestia-node to perform any additional validation for max blob size b/c I expect it to be covered by CheckTx. @vgonkivs thoughts?

[Wondertan]

I think if that's a stateless check, we should add it to our validation path. Specifically in the blob constructor on our side.

[rootulp]

The stateless check depends on a versioned constant (SquareSizeUpperBound) and a hard-coded constant (MaxBlockSizeBytes). We can add it to blob constructor on celestia-node side with the caveat that the versioned constant may change in the future.

[Wondertan]

The version, in this case, should be the one binary was built with.

[rootulp]

The versioned constant is dependent on the app version which is currently v1 (see here) and likely will be incremented when there's a new major version of celestia-app.

[vgonkivs]

Can we simply use LatestVersion constant even when It will be v2,v3...?

[rootulp]

I think celestia-node can use LatestVersion because I would expect celestia-app v1.x.x LatestVersion to be v1 and celestia-app v2.x.x's LatestVersion to be v2.

[rootulp]

Closing as won't do. We've improved the behavior of celestia-app's CheckTx in celestiaorg/celestia-app#2202 so txs with a total blob size that is too large will be rejected at the mempool level.