-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR: DAS node-types aka partial nodes #388
Comments
Note that the currently-used nomenclature is that:
So this ADR might be better named "partial node" rather than "DAS full node." |
Thanks, @adlerjohn. I updated the title and the description. As discussed on a sync call this was coming from the perspective on how to modify the existing tendermint fullnodes and prep for DAS. My understanding (also from discussions with @musalbas e.g. here and on calls) was that this should be the immediate next priority. It is debatable if partial nodes need to "participate in consensus" (meaning running the consensus reactor that deals with these messages and basically also running the same code as validators without actively signing messages). It would be good to have a clear decision on this before we move in one or the other direction. Here is a full overview of the reactors a regular tendermint fullnode runs: https://github.com/tendermint/tendermint/blob/de5cf42ed5ab19d93a4da48b33454f32c1c899d6/docs/architecture/adr-052-tendermint-mode.md#decision Some of the modes (node-types) in the above ADR should also end up in the specs. Or at least their relation to our node-types IMO. I'll open an issue about this in the specs repo shortly. |
closing this in favour of #435 |
* Fix formatting of changelog entries Signed-off-by: Thane Thomson <[email protected]> * Prepare release changelog Signed-off-by: Thane Thomson <[email protected]> * Build changelog Signed-off-by: Thane Thomson <[email protected]> * version: Bump to v0.34.27 Signed-off-by: Thane Thomson <[email protected]> * Update contributor list in thanks section Signed-off-by: Thane Thomson <[email protected]> * Move changelog entry to v0.34.27 release Signed-off-by: Thane Thomson <[email protected]> * Fix changelog entry formatting Signed-off-by: Thane Thomson <[email protected]> * Rebuild changelog Signed-off-by: Thane Thomson <[email protected]> --------- Signed-off-by: Thane Thomson <[email protected]>
Summary
Similar to the ADR for the DAS light-client, we should describe the modifications required for other DAS node-types.
Details
Some aspects are better described in separate focused ADRs. See:
Everything else that isn't already covered by these other ADRs, should still be captured in the ADR this issue is about. Including added command-line flags and config options. Non-exhaustive list of these:
Other implications, like the inability to serve full block via RPC (related: #189, #195)
The text was updated successfully, but these errors were encountered: