Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split WaitUntilStartedAndForwardPorts() into two funcs #3599

Open
staheri14 opened this issue Jun 19, 2024 · 0 comments
Open

Split WaitUntilStartedAndForwardPorts() into two funcs #3599

staheri14 opened this issue Jun 19, 2024 · 0 comments
Assignees
@staheri14
Labels
knuu item is directly related to the usage of knuu WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@staheri14
Copy link
Contributor 

          This can be done in a follow up but this function should really be two different functions since it performs two different actions.

In fact, I would be more in favour of grouping StartAsync and WaitInstanceIsRunning together

Originally posted by @cmwaters in #3515 (comment)
@staheri14 staheri14 mentioned this issue Jun 19, 2024
Merged
@staheri14 staheri14 self-assigned this Jun 19, 2024
@staheri14 staheri14 added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols knuu item is directly related to the usage of knuu and removed needs:triage labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
knuu item is directly related to the usage of knuu WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@staheri14