Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of namespace should be before loops #2110

Closed
andrijamitrovic23 opened this issue Jul 17, 2023 · 1 comment · Fixed by #2113
Closed

Calculation of namespace should be before loops #2110

andrijamitrovic23 opened this issue Jul 17, 2023 · 1 comment · Fixed by #2113
Assignees
@rootulp
Labels
audit item is from an audit

Comments

@andrijamitrovic23
Copy link

Namespace calculation is dependent only on blob data and not on any of the data from the loops where the calculation is done. This should be moved outside of for loops.
@rootulp rootulp self-assigned this Jul 17, 2023
@rootulp
Copy link
Collaborator

rootulp commented Jul 17, 2023

Great refactor idea!

@rootulp rootulp added this to the Post-mainnet milestone Jul 17, 2023
@rootulp rootulp added the audit item is from an audit label Jul 17, 2023
@rootulp rootulp mentioned this issue Jul 17, 2023
Merged
rootulp added a commit that referenced this issue Jul 17, 2023
@rootulp
refactor: calculate namespace before loop (#2113)
7faf094 
Closes #2110
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
refactor: calculate namespace before loop (#2113)
fee27a3 
Closes celestiaorg/celestia-app#2110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
audit item is from an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: calculate namespace before loop rootulp/celestia-app
2 participants
@rootulp @andrijamitrovic23