Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs: update diagrams for arranging available data into shares #1424

Closed
rootulp opened this issue Feb 23, 2023 · 2 comments
Closed

specs: update diagrams for arranging available data into shares #1424

rootulp opened this issue Feb 23, 2023 · 2 comments
Assignees
@rootulp
Labels
specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 23, 2023

Context

https://github.com/celestiaorg/celestia-app/blob/specs-staging/specs/src/specs/data_structures.md#arranging-available-data-into-shares

Problem

These diagrams no longer reflect the implementation:

  1. https://github.com/celestiaorg/celestia-app/blob/specs-staging/specs/src/specs/figures/rs2d_originaldata_reserved.svg
  2. https://github.com/celestiaorg/celestia-app/blob/specs-staging/specs/src/specs/figures/rs2d_originaldata_message.svg

Proposal

  • Remove the blue square for evidence because it is no longer written to the data square
  • Add a blue square for PayForBlob transactions
@rootulp rootulp added the specs directly relevant to the specs label Feb 23, 2023
@rootulp rootulp self-assigned this Mar 1, 2023
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 1, 2023

Thanks to @staheri14 for identifying this inconsistency!

@rootulp rootulp mentioned this issue Mar 1, 2023
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 6, 2023

Closed by #1436

@rootulp rootulp closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
specs directly relevant to the specs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp