Skip to content

Create a not-pre release? #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mathiasose opened this issue Oct 1, 2020 · 5 comments
Closed

Create a not-pre release? #4

mathiasose opened this issue Oct 1, 2020 · 5 comments

Comments

@mathiasose
Copy link

Thanks for your work on Celery!

Now that Celery 5 is out I want to use this package as a dev dependency (with pipenv), but since the latest release is 0.0.0a1 I have to set allow_prereleases = true in my Pipfile to use it.

Perhaps this package is ready to be re-released as 1.0.0?

@graingert
Copy link
Collaborator

@mathiasose does depending on pytest[celery] work?

@mathiasose
Copy link
Author

mathiasose commented Oct 6, 2020

Unfortunately, it does not, I get fixture 'celery_session_worker' not found when I remove pytest-celery and install pytest[celery] instead.

Actually the same thing happens when I install celery[pytest] too, even though the docs suggest that that should work. Adding pytest_plugins = 'celery.contrib.pytest' to the pytest config also does not work for me. pytest-celery seems to be the only way I get pytest to find the fixtures.

Edit:

Actually after writing that I looked at the docs again and saw that the instructions had been updated. Putting pytest_plugins = ("celery.contrib.pytest", ) in conftest.py works! So my immediate problem is solved, although it still wouldn't harm to give this package a new release.

@graingert
Copy link
Collaborator

done!

@graingert
Copy link
Collaborator

graingert commented May 6, 2021

installing celery[pytest] works for me:

$ pip install celery[pytest]
Collecting celery[pytest]
  Using cached celery-5.0.5-py3-none-any.whl (392 kB)
Requirement already satisfied: click-didyoumean>=0.0.3 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (0.0.3)
Requirement already satisfied: vine<6.0,>=5.0.0 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (5.0.0)
Requirement already satisfied: click-repl>=0.1.6 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (0.1.6)
Requirement already satisfied: pytz>dev in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (2021.1)
Requirement already satisfied: click-plugins>=1.1.1 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (1.1.1)
Requirement already satisfied: click<8.0,>=7.0 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (7.1.2)
Requirement already satisfied: kombu<6.0,>=5.0.0 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (5.0.2)
Requirement already satisfied: billiard<4.0,>=3.6.3.0 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from celery[pytest]) (3.6.4.0)
Collecting pytest-celery
  Using cached pytest_celery-0.0.0-py2.py3-none-any.whl (2.5 kB)
Requirement already satisfied: six in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from click-repl>=0.1.6->celery[pytest]) (1.15.0)
Requirement already satisfied: prompt-toolkit in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from click-repl>=0.1.6->celery[pytest]) (3.0.18)
Requirement already satisfied: amqp<6.0.0,>=5.0.0 in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from kombu<6.0,>=5.0.0->celery[pytest]) (5.0.6)
Requirement already satisfied: wcwidth in /home/graingert/.virtualenvs/testing39/lib/python3.9/site-packages (from prompt-toolkit->click-repl>=0.1.6->celery[pytest]) (0.2.5)
Installing collected packages: celery, pytest-celery
Successfully installed celery-5.0.5 pytest-celery-0.0.0
$ pytest
============================================================================================================================== test session starts ===============================================================================================================================
platform linux -- Python 3.9.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/graingert/projects/pytest, configfile: pyproject.toml, testpaths: testing
plugins: celery-0.0.0, anyio-3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@graingert @mathiasose and others