Shortcut key behavior is inconsistent after upgrade 128.4.90

[ConstRico]

Is there an existing issue for this?

• I have searched both open/closed issues, no issue already exists.

CefSharp Version

128.4.90

Operating System

Windows 10

Architecture

x64

.Net Version

.Net4.8

Implementation

WPF

Reproduction Steps

We implemented the IKeyboardHandler interface, where its methods (OnKeyEvent and OnPreKeyEvent) consistently return false and press any shortcut keys like ctrl+s

Expected behavior

In version 127.3.50, regardless of the shortcut keys pressed, they do not function as intended.

Actual behavior

After upgrading to version 128.4.90, all shortcut keys operate correctly.

Regression?

No response

Known Workarounds

No response

Does this problem also occur in the CEF Sample Application

Yes using WPF/OffScreen command line args

Other information

We are interested in understanding why the behavior has changed and What modifications do we need to make in the code to ensure it functions as it did previously?

[mitchcapper]

By inconsistent I assume you mean it performs the native action rather than (what it sounds like you want) of not doing anything.

You say OnKeyEvent / OnPreKeyEvent you are returning false but if you want to be fake 'handling' them you would want true:

CefSharp/CefSharp/Handler/IKeyboardHandler.cs

Line 56 in 2ebad4d

/// <returns>Return true if the keyboard event was handled or false otherwise.</returns>

as for why 128 breaks things? That is when the alloy boostrap was first removed this was an upstream change likely this is the cause.

[ConstRico]

@mitchcapper So is there any solution now that will work the same way as the alloy boostrap? such as password manager won't be displayed when we entered a password

[mitchcapper]

Well setting CefSharpSettings.RuntimeStyle = CefRuntimeStyle.Alloy will ensure you use alloy style for as long as cef supports it. In terms of getting the old behavior, to start, you need to update your keyboard handler. I don't think they changed but I could be wrong, either way returning false seems wrong if you are saying the shortcuts are handled.

As for other features, like the password manager, some things you can disable using preferences ie:

.To find the exact name use the cefclient.exe under the other tests their prefs you can export the changed only settings as json. Do that, change something, export again and you can see the exact pref name. This is a greatly expanded set of things one can set. I am pretty positive the password manager disabling by prefs would be the way to go.

You can also disable several features by command line ie:

[mitchcapper]

Actually think I did have password manager specifically disabled by:

Note these pref commands are not what you would use, you would want requestcontext.SetPreference or contextHandler.SetPreferenceOnContextInitialized

[ConstRico]

@mitchcapper Hi Mitch, I have implemented the solutions you suggested. However, it seems that CefSharpSettings.RuntimeStyle = CefRuntimeStyle.Alloy has been deprecated in Cef, and maintaining the alloy style now requires additional configuration. Additionally, the password manager cannot be disabled after integrating your code. Thank you very much for your assistance!

[mitchcapper]

I dont think the window styling is deprecated but assuming you are using WPF and not WPF.HwndHost then it currently always is alloy style:

CefSharp/CefSharp/IWindowInfo.cs

Lines 75 to 77 in 2ebad4d

	/// Optionally change the runtime style. Alloy style will always be used if
	/// <see cref="WindowlessRenderingEnabled"/> is true. See <see cref="CefRuntimeStyle"/>
	/// documentation for details.

I don't know what code you did to try above. Using
browser.RequestContext = new RequestContextBuilder().WithPreference("autofill.enabled", false).WithPreference("credentials_enable_service", false).Create();

when creating the browser doesn't quite work as I expected.

Once the window is fully loaded if I do:

It correctly works without issue. You can visit: chrome://password-manager/settings to verify.

[naruto00fa]

Hi @mitchcapper , since upgrading to v128.4.90 makes some Chrome behaviors show up, can I find what prefs and command lines Alloy Bootstrap used to set some where? I want to make all behaviors(not UI styles, just functionalities like password manage) same as Alloy Bootstrap ones.

I searched but not find what Allow Bootstrap does about the pref and commands, could you offer some help on it?

[mitchcapper]

I should mention above I only tested on 130 as well so I don't know for 128 if it all works as expected.

can I find what prefs and command lines Alloy Bootstrap used to set some where?

It doesn't work like that. Under the covers CEF had a massive switch from the aging and limited alloy bootstrap runtime to the chromium bootstrap runtime. Essentially this is building CEF on top of a higher level of chromium bringing a massive slew of features that CEF could never do, and handed of many things that CEF had to essentially re-implement.

It isn't that CEF was turning off the password manager before, it is that CEF was much lower so the password manager code did not exist. Think of it like a car and before CEF was directly on top of an engine. You didn't need to disable the radio or say remove the windows in the passenger car doors as you were from-scratch on top of the engine. This also means if you wanted an infotainment system for your car you basically had to build it from scratch. Now with the Chrome runtime essentially CEF is taking an entire car and modding it from there to allow the same low level control but still have the capability of all those high level chromium features. The car comes with many bells and whistles we may not want though so we need to disable them to get something similar to the bare bones base from before.

There are many things one would need to tweak to get it to be as limited as the old CEF, and I don't think anyone has a list of prefs to help do that. Your choice is limited. Stick with an older version that will never update or accept their runtime change and change the prefs to function as you like.

[naruto00fa]

@mitchcapper Great answer, thanks a lot.

By the way RequestContext disables password works fine on 128.

Thanks for you clarification, we'll choose one from the limited choice.

[amaitland]

Converting to discussion as this isn't a bug.

However, it seems that CefSharpSettings.RuntimeStyle = CefRuntimeStyle.Alloy has been deprecated in Cef, and maintaining the alloy style now requires additional configuration.

The Alloy Bootstrap was deprecated and subsequently removed. The Alloy styling is different, still supported. OSR which is used by the WPF implementation only works with Alloy styling.

It isn't that CEF was turning off the password manager before, it is that CEF was much lower so the password manager code did not exist. Think of it like a car and before CEF was directly on top of an engine. You didn't need to disable the radio or say remove the windows in the passenger car doors as you were from-scratch on top of the engine. This also means if you wanted an infotainment system for your car you basically had to build it from scratch. Now with the Chrome runtime essentially CEF is taking an entire car and modding it from there to allow the same low level control but still have the capability of all those high level chromium features. The car comes with many bells and whistles we may not want though so we need to disable them to get something similar to the bare bones base from before.

@mitchcapper Excellent description! I'll be sure to reference this 😄

There are many things one would need to tweak to get it to be as limited as the old CEF, and I don't think anyone has a list of prefs to help do that.

I've seen a couple of discussions regarding this which might provide helpful. I haven't tested these yet.

https://www.magpcss.org/ceforum/viewtopic.php?f=6&t=19898&start=10#p55835
https://www.magpcss.org/ceforum/viewtopic.php?f=6&t=19835

#4991 will track adding SetContentSetting

[amaitland]

Also chromiumembedded/cef#3796 (comment)

[amaitland]

Popup blocker is now enabled by default and may need to be disabled/configured to allow popups in some circumstances.

#4940 (comment)