Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't install on blender 2.70a #25

Open
x-bee opened this issue May 18, 2014 · 6 comments
Open

can't install on blender 2.70a #25

x-bee opened this issue May 18, 2014 · 6 comments

Comments

@x-bee
Copy link
Contributor

x-bee commented May 18, 2014

Some change in the API, I think,
this line seems to be incorrect with the latest one

if bpy.app.build_revision >= b'50938' else "FILENAME"

@cedricpinson
Copy link
Owner

Could you make a pull request please ?

@x-bee
Copy link
Contributor Author

x-bee commented May 22, 2014

Sorry, i'm completely new on github, what is a pull request ?

@x-bee x-bee closed this as completed May 22, 2014
@cedricpinson cedricpinson reopened this May 22, 2014
@cedricpinson
Copy link
Owner

you can information here https://help.github.com/articles/using-pull-requests
it's like sending a patch

@minghia
Copy link

minghia commented May 28, 2014

The line can be changed to:
FILE_NAME = "FILE_NAME" if bpy.app.version[0] >= 2 and bpy.app.version[1] >= 63 else "FILENAME"

For whatever reason the bpy.app.build_revision is no longer present in the Python API but I can't find when it disappeared as looking through the ChangeLog on www.blender.org show nothing.

@cedricpinson
Copy link
Owner

If you have an update, could you provide a new pull request ?

@x-bee
Copy link
Contributor Author

x-bee commented May 28, 2014

I've made a change yesterday but I may have not understood how it works ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants