Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests became mandatory with planetary name support #117

Closed
ManonMarchand opened this issue Sep 19, 2024 · 1 comment · Fixed by #124
Closed

requests became mandatory with planetary name support #117

ManonMarchand opened this issue Sep 19, 2024 · 1 comment · Fixed by #124
Labels
bug
Milestone
0.5.1

Comments

@ManonMarchand
Copy link
Member

ManonMarchand commented Sep 19, 2024 •
edited
Loading

We have to make it optional or add it officially in our dependencies, see failure of conda forge package
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1031951&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

conda-forge/ipyaladin-feedstock#16

TODO : add CI without optional dependencies
@tboch
Copy link
Contributor

tboch commented Sep 20, 2024 •
edited
Loading

Well, we could also remove requests dependency and replace the code with urllib.request calls.

Having an additional dependency just for this feels weird to me.

@ManonMarchand ManonMarchand added this to the 0.5.1 milestone Sep 20, 2024
@ManonMarchand ManonMarchand linked a pull request Sep 30, 2024 that will close this issue
fix: remove rogue dependency #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.5.1
Development

Successfully merging a pull request may close this issue.

fix: remove rogue dependency cds-astro/ipyaladin
2 participants
@tboch @ManonMarchand