Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in method resolveResourceFromInstrinsic #1898

Open
onstwedder opened this issue Feb 11, 2025 · 1 comment
Open

Typo in method resolveResourceFromInstrinsic #1898

onstwedder opened this issue Feb 11, 2025 · 1 comment
Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@onstwedder
Copy link
Contributor

General Issue

Typo in code

The Question

Hi,

This might no have high priority, however the method here in nag-rules.ts is called: resolveResourceFromInstrinsic

I feel it is a typo and should be resolveResourceFromIntrinsic

cdk-nag version

v2.35.15

Language

Typescript

Other information

No response
@onstwedder onstwedder added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 11, 2025
@onstwedder
Copy link
Contributor Author

added a PR

mergify bot pushed a commit that referenced this issue Feb 17, 2025
@onstwedder
fix: fixed typo resolveResourceFromInstrinsic #1898 (#1900)
3d6bc3c 
Fixes #

Removed all references to resolveResourceFromIn**s**trinsic, changed it into resolveResourceFromIntrinsic.

Kept the old resolveResourceFromIntrinsic added @deprecated so it would not kill backward compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onstwedder