Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmax and pmin not working on vclMatrix #149

Open
asauvat opened this issue Jan 18, 2019 · 2 comments
Open

pmax and pmin not working on vclMatrix #149

asauvat opened this issue Jan 18, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@asauvat
Copy link

asauvat commented Jan 18, 2019

Hi,

Thanks for that great package! Unfortunately I cannot make the pmin and pmax functions work. The simple example :

pmax(vclMatrix(rep(1,100),ncol=10,nrow=10),vclMatrix(rep(2,100),ncol=10,nrow=10))

returns :

Error in cpp_vclMatrix_pmax(B@address, is(B, "vclMatrix"), B@address,  : 
  Not compatible with requested type: [type=S4; target=double].

Am I using the functions correctly ?

@cdeterman
Copy link
Owner

That is strange, I will need to take a look. To make sure I understand, are you saying that pmax/pmin work on gpuMatrix objects? I suspect this potentially has to do with S4 methods not being generic but I need to be sure I understand the problem. Also, is this the CRAN or dev version of the package?

@asauvat
Copy link
Author

asauvat commented Jan 22, 2019

Hello,

Thanks for answering that fast! Using gpuMatrix returns the exact same error. I tried both CRAN and dev packages, both behaving the same.

@cdeterman cdeterman added the bug label Feb 26, 2019
@cdeterman cdeterman self-assigned this Feb 26, 2019
@cdeterman cdeterman added this to the 2.1.0 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants