Version 3.0.0 of the module does not include the required node_modules

[mgroeneweg]

Version 3.0.0 of the module does not include the required node_modules.

Running npm install inside the module folder in javascriptsources could fix this but this brings in 700+ folders with well over 200Mb of files. Way too much to check in.

Deployment packages created with this release will also fail because the packager will not have these files as well.

Please include the node modules for the minimum required modules.

[ElineMendix]

Also running into this issue, would love to see it fixed.

[cdcharlebois]

Please try the beta release here and let me know if that resolves your issue

[mgroeneweg]

I downloaded the beta. It is well over 40Mb unpacked and still includes large libraries like React, React Native and the react devtools. Pruning non-JS stuff is a step but not enough. For NativeFileDocuments, I have removed any library that turned out to be dev dependency. I ship only 11 modules with the module, it would have been over 700 otherwise. Same here. The library does not need all these modules to work, these are dev dependencies.

[cdcharlebois]

I'm trying to find a middle ground between including no dependencies and letting the developer figure it out versus providing what's needed, without spending hours manually combing through dependencies. The script is a huge help. Do you have any other suggestions for automated ways to remove the extra dev dependencies? For NativeFileDocuments, did you just manually traverse the package.json files?

[mgroeneweg]

For NativeFileDocuments, I moved any modules except the ones I installed away to a temp folder. Then I tested and moved back modules until I got no errors anymore. But I think there are libraries or even just NPM commands that let you weed out the dev dependencies.

[cdcharlebois]

interestingly, the @react-native-firebase packages don't list any dev dependencies

[cdcharlebois]

will try with npm prune --production and upload a new version here soon

[mgroeneweg]

Would be interesting if that works. I will then try to see how that works on NativeFileDocuments

[cdcharlebois]

after npm prune --production no packages were removed and the exported mpk is still the same size (14.7MB). It seems like most deps are listed as peer

{
  "added": 0,
  "removed": 0,
  "changed": 44,
  "audited": 723,
  "funding": 33,
  "audit": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 6,
      "high": 2,
      "critical": 0,
      "total": 8
    },
    "dependencies": {
      "prod": 77,
      "dev": 0,
      "optional": 0,
      "peer": 646,
      "peerOptional": 0,
      "total": 722
    }
  }
}

[cdcharlebois]

tried removing node_modules and running npm i --production to same result. Not sure how to safely remove peer deps without doing it manually.

[mgroeneweg]

I ran npm install again in NativeFileDocuments and got the 300+ node modulesback. Then I ran npm prune --omit dev --omit peer and only 22 modules were still in node_modules. Perhaps that trick, and then pruning non-JS stuff, will work here.