Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShorSimulator does not work without emulation #26

Open
hillmich opened this issue Jun 11, 2021 · 0 comments
Open

ShorSimulator does not work without emulation #26

hillmich opened this issue Jun 11, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@hillmich
Copy link
Contributor

hillmich commented Jun 11, 2021 •
edited
Loading

The ShorSimulator does not work without emulation. Thanks to @hassanmallahzadeh for finding this bug.

Suggested fix: Remove the non-emulation code from ShorSimulator and write a new class ShorBeauregardSimulator (or similar).
@hillmich hillmich added the bug Something isn't working label Jun 11, 2021
hillmich added a commit that referenced this issue Mar 3, 2023
@hillmich
Remove non-emulated shor sim (see issue #26
62d6c0d
@hillmich hillmich mentioned this issue Mar 3, 2023
Merged
hillmich added a commit that referenced this issue Mar 8, 2023
@hillmich
Add cpp-linter action (and improve coverage #199)
753b4d3 
* Add cpp-linter action
* Include OpenCV to lint frqi.cpp
* Add to .gitignore
* Added tests/coverage
* Refactored ShorSim to increase coverage
* Remove non-emulated shor sim (see issue #26)
* Use plain std::unique_ptr to store the quantum computation for the simulators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hillmich