Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue: Ensure ARIA roles, states, and properties are valid #5157

Open
karentsao opened this issue Nov 1, 2023 · 3 comments
Open

Comments

@karentsao
Copy link

Module:
Collection Detail: Video Type

Violation:
Ensure ARIA roles, states, and properties are valid

Description:
[Issue - priority raised]
Some elements contain invalid ARIA attributes or values (states, roles, and properties). Issues include:

  • When using aria-valuemin you also must use aria-valuemax.
  • aria-controls and aria-owns point to non-existent ID Values

[User Impact]
When ARIA attributes (state, roles, and properties) are not valid according to the specification or are not used correctly, assistive technology may not function as expected.

*Major Sheet Row 9 in https://docs.google.com/spreadsheets/d/1L9mwZ55UNKOUOVC_w-fuUjpbeNTyXVE5/edit#gid=512445576

@jmaikrueger
Copy link

Adding the last email exchange between Karen and Nyk:

From: Hui Tsao <[email protected]>
Sent: Friday, March 3, 2023 1:12 PM
To: [email protected] <[email protected]>
Cc: Lydia Li <[email protected]>; Jacqueline M Krueger <[email protected]>; Natalia Dittren <[email protected]>
Subject: Re: Questions regarding Mediathread accessibility issues
 
Hi Nik,

Thanks a lot for the fix!

I merged the three files from https://github.com/ccnmtl/mediathread/pull/4848 but the aria-valuemax field still not there... After looking into it further, I see this commit which might be related: e8b6af2. Do I need to take this one as well?

Thanks,
Karen

From: Nikolas J. Nyby <[email protected]>
Sent: Thursday, March 2, 2023 12:40 PM
To: Hui Tsao <[email protected]>
Cc: [email protected] <[email protected]>; Lydia Li <[email protected]>; Jacqueline M Krueger <[email protected]>; Natalia Dittren <[email protected]>
Subject: Re: Questions regarding Mediathread accessibility issues
 
Hi Karen,
Yeah, so I updated the juxtapose code with these changes:
ccnmtl/juxtapose#1319
#4848

There is a new version of the compiled juxtapose code here, if you don't want to build it yourself: https://github.com/ccnmtl/mediathread/blob/master/media/juxtapose/bundle-k.js

We will look at this other stuff when we can - thank you for your patience with our slower progress on this front.

Nik

@nikolas
Copy link
Member

nikolas commented Dec 18, 2023

On this ticket it's unclear what the exact issue is. If there are issues with aria attributes, they can be resolved either within mediathread or juxtapose (code is here: https://github.com/ccnmtl/juxtapose)

But, what is the exact error, and what needs to change?

@karentsao
Copy link
Author

Hi Nik,

I still not see aria-valuemax when aria-valuemin is presented after update my juxtapose.

Maybe you don't understand my question. Let me explain it again here:

You asked me to update my juxtapose with

I did both but still no aria-valuemax. Then I digged into your code and found e8b6af2.
If I also pull this changes in, aria-valuemax will show up. I just want to quickly confirm that if e8b6af2 is needed.

Thanks,
Karen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants