Accessibility issue: Ensure ARIA roles, states, and properties are valid

[karentsao]

Module:
Collection Detail: Video Type

Violation:
Ensure ARIA roles, states, and properties are valid

Description:
[Issue - priority raised]
Some elements contain invalid ARIA attributes or values (states, roles, and properties). Issues include:

• When using aria-valuemin you also must use aria-valuemax.
• aria-controls and aria-owns point to non-existent ID Values

[User Impact]
When ARIA attributes (state, roles, and properties) are not valid according to the specification or are not used correctly, assistive technology may not function as expected.

*Major Sheet Row 9 in https://docs.google.com/spreadsheets/d/1L9mwZ55UNKOUOVC_w-fuUjpbeNTyXVE5/edit#gid=512445576

[jmaikrueger]

Adding the last email exchange between Karen and Nyk:

From: Hui Tsao <[email protected]>
Sent: Friday, March 3, 2023 1:12 PM
To: [email protected] <[email protected]>
Cc: Lydia Li <[email protected]>; Jacqueline M Krueger <[email protected]>; Natalia Dittren <[email protected]>
Subject: Re: Questions regarding Mediathread accessibility issues
 
Hi Nik,

Thanks a lot for the fix!

I merged the three files from https://github.com/ccnmtl/mediathread/pull/4848 but the aria-valuemax field still not there... After looking into it further, I see this commit which might be related: e8b6af2. Do I need to take this one as well?

Thanks,
Karen

From: Nikolas J. Nyby <[email protected]>
Sent: Thursday, March 2, 2023 12:40 PM
To: Hui Tsao <[email protected]>
Cc: [email protected] <[email protected]>; Lydia Li <[email protected]>; Jacqueline M Krueger <[email protected]>; Natalia Dittren <[email protected]>
Subject: Re: Questions regarding Mediathread accessibility issues
 
Hi Karen,
Yeah, so I updated the juxtapose code with these changes:
* ccnmtl/juxtapose#1319
* #4848

There is a new version of the compiled juxtapose code here, if you don't want to build it yourself: https://github.com/ccnmtl/mediathread/blob/master/media/juxtapose/bundle-k.js

We will look at this other stuff when we can - thank you for your patience with our slower progress on this front.

Nik

[nikolas]

On this ticket it's unclear what the exact issue is. If there are issues with aria attributes, they can be resolved either within mediathread or juxtapose (code is here: https://github.com/ccnmtl/juxtapose)

But, what is the exact error, and what needs to change?

[karentsao]

Hi Nik,

I still not see aria-valuemax when aria-valuemin is presented after update my juxtapose.

Maybe you don't understand my question. Let me explain it again here:

You asked me to update my juxtapose with

• Add max prop to TimecodeEditor juxtapose#1319
• Update juxtapose to latest master #4848

I did both but still no aria-valuemax. Then I digged into your code and found e8b6af2.
If I also pull this changes in, aria-valuemax will show up. I just want to quickly confirm that if e8b6af2 is needed.

Thanks,
Karen