Skip to content

Commit e751aae

Browse files
committed
Merge pull request #307 from ccnmtl/term-counts
Term count aggregation fix PMT#102471
2 parents e2bb6cb + f1cc91c commit e751aae

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

mediathread/assetmgr/views.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,6 @@ def get_context(self, request, assets, notes):
623623
def add_metadata(self, request, assets):
624624
# metadata for all notes associated with these assets
625625
# is displayed in the filtered list.
626-
# Not sure this is exactly right...will discuss with team
627626
notes = SherdNote.objects.get_related_notes(
628627
assets, self.record_owner or None, self.visible_authors,
629628
self.all_items_are_visible)

mediathread/taxonomy/api.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,15 @@ def render_related(self, request, object_list):
147147
return values
148148

149149
def render_for_course(self, request, object_list):
150-
term_counts = TermRelationship.objects.none()
150+
related = TermRelationship.objects.none()
151151
if len(object_list) > 0:
152152
related = TermRelationship.objects.get_for_object_list(object_list)
153-
term_counts = related.values('term').annotate(count=Count('id'))
154153

155154
data = []
156155
for vocabulary in Vocabulary.objects.get_for_object(request.course):
157156
ctx = self.render_one(request, vocabulary)
158157
for term in ctx['term_set']:
159-
qs = term_counts.filter(term=term['id'])
160-
term['count'] = qs[0]['count'] if len(qs) > 0 else 0
158+
term['count'] = related.filter(term__id=term['id']).count()
161159
data.append(ctx)
162160

163161
data.sort(lambda a, b: cmp(a['display_name'].lower(),

terrain.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1008,7 +1008,13 @@ def there_is_a_state_name_panel(step, state, name):
10081008
name -- composition, assignment, discussion, collection
10091009
"""
10101010
selector = "td.panel-container.%s.%s" % (state.lower(), name.lower())
1011-
panel = world.browser.find_element_by_css_selector(selector)
1011+
1012+
try:
1013+
panel = world.browser.find_element_by_css_selector(selector)
1014+
except NoSuchElementException:
1015+
time.sleep(1)
1016+
panel = world.browser.find_element_by_css_selector(selector)
1017+
10121018
assert panel is not None, "Can't find panel named %s" % panel
10131019

10141020

0 commit comments

Comments
 (0)