Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatemplate plugin incompatible with data plugin 2016-03-11 #21

Closed
tmo26 opened this issue Mar 13, 2016 · 2 comments
Closed

datatemplate plugin incompatible with data plugin 2016-03-11 #21

tmo26 opened this issue Mar 13, 2016 · 2 comments

Comments

@tmo26
Copy link

tmo26 commented Mar 13, 2016

Release 2015-08-10a "Detritus"
data plugin Installed version: 2016-01-24

datatemplate plugin:
Installed version: 2011-08-27 <- wrong due to #19
Your last update: Wed, 03 Feb 2016 23:46:58 +0100
Available version: 2014-01-12 <- installed

When installing data plugin version 2016-03-11, the wiki stops working and shows only blank white pages, which makes it completely unusable.

Solution: Disable datatemplate plugin.

The reason for the datatemplate breaking the wiki: see splitbrain/dokuwiki-plugin-data#191

The only change made between the releases is the renaming of a constructor. That should be unproblematic unless something calls that constructor directly by it's name instead of just calling new on the class name. I don't see something like this in the data plugin itself, so it could only happen when a different plugin makes use of the data plugin.

Could you please fix this error by adapting the datatemplate plugin to the changes made to the data plugin in version 2016-03-11?

@tmo26 tmo26 changed the title datatemplate datatemplate plugin incompatible with data plugin 2016-03-11 Mar 13, 2016
@butch2k
Copy link

butch2k commented Apr 1, 2016

Edit syntax/list.php
replace parent::syntax_plugin_data_table();
by parent::__construct();

@tmo26
Copy link
Author

tmo26 commented May 2, 2016

Confirmed working!
Please include this change in the official distribution of the plugin on https://www.dokuwiki.org/plugin:datatemplate

@tmo26 tmo26 closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants