Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax highlighting #2

Open
pioz opened this issue Feb 14, 2018 · 5 comments · May be fixed by #6
Open

Wrong syntax highlighting #2

pioz opened this issue Feb 14, 2018 · 5 comments · May be fixed by #6

Comments

@pioz
Copy link

pioz commented Feb 14, 2018

Here a screenshot:

screen

@sethomas

This comment has been minimized.

@darlanmendonca

This comment has been minimized.

@ccampbell
Copy link
Owner

Thanks, that last one is the same issue as #1. I do not have a lot of time to devote to this project, but I would gladly accept pull requests to fix these.

@ccampbell
Copy link
Owner

The last two comments had to do with template literals. Those should be fixed. @pioz I believe your issue is still valid. Also one minor annoyance that I have to figure out.

Doing this will not highlight correctly

return (
    <div>
        whatever
    </div>
);

But this is fine

return 
    <div>
        whatever
    </div>;

And so is this

return (<div>
    whatever
</div>);

@ccampbell ccampbell reopened this Jun 14, 2018
@A-312
Copy link

A-312 commented May 12, 2020

@ccampbell Your first example seem good, with the current version :

image

@A-312 A-312 linked a pull request May 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants