Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag to unconditionally disable file locking usage #955

Open
kay-lambdadelta opened this issue Feb 27, 2025 · 2 comments · May be fixed by #895
Open

Add feature flag to unconditionally disable file locking usage #955

kay-lambdadelta opened this issue Feb 27, 2025 · 2 comments · May be fixed by #895

Comments

@kay-lambdadelta
Copy link

I would like file locking to be behind a (default) feature flag to unconditionally use the fallback database file accessor. Currently, if you try to compile this library to a target rust believes is a unix-like and that target does not support flock the library does not compile (an example is the ctru-rs library with the 3ds).
@cberner
Copy link
Owner

cberner commented Feb 28, 2025

Can you give this PR a try and see if it resolves your issue? #895

file_lock will be stable in 1.87, I believe. And then I can land that which will allow the libc dependency to be removed

@kay-lambdadelta
Copy link
Author

Yes this resolves the issue. Thank you.

@cberner cberner linked a pull request Mar 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: use std file_lock cberner/redb
2 participants
@cberner @kay-lambdadelta