Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Nix users that extension directory must be mutable #419

Open
sgoudham opened this issue Aug 5, 2024 · 1 comment
Open

Notify Nix users that extension directory must be mutable #419

sgoudham opened this issue Aug 5, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs investigation

Comments

@sgoudham
Copy link
Contributor

sgoudham commented Aug 5, 2024

Some users manage their VSCode via NixOS/NixOS Home Manager which results in the extension directory being immutable. As stated in the README, the extension makes the assumption that the extension directory is mutable in order to configure the theme via the options provided.

A isMutable function has already been implemented which we will want to build off of to notify Nix users that the advice in the README should be followed:

// TODO: listen to this to determine if a user is using Nix, redirect to README
export const isMutable = async (uri: Uri): Promise<boolean> => {
return workspace.fs.stat(uri).then(
(stat) => stat.permissions !== FilePermission.Readonly,
(error) => error,
);
};


Arises from #415

@sgoudham sgoudham added the enhancement New feature or request label Aug 5, 2024
@sgoudham
Copy link
Contributor Author

sgoudham commented Nov 8, 2024

I tried implementing this earlier and it was an absolute pain to debug. I thought I'd be able to mimic the error on a non nix setup by setting the files to read only but it seems more complicated than that as I wasn't succeeding in getting the popup to show up when I wanted it to.

@sgoudham sgoudham added needs investigation help wanted Extra attention is needed labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs investigation
Projects
None yet
Development

No branches or pull requests

1 participant