Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The highlight color for the closing bracket tag in HTML is inconsistent #405

Open
vinnlee opened this issue Jul 2, 2024 · 1 comment
Open
Labels
bug Something isn't working syntax

Comments

@vinnlee
Copy link

vinnlee commented Jul 2, 2024

I noticed there is an inconsistent highlight color for the closing bracket of the style and script tags.
Additionally, a similar issue occurs with the closing quote of inline styles, as shown in the image below.

112702

@backwardspy
Copy link
Member

thanks for raising this! looking at the textmate scopes on these characters reveals it's related to the inline css and javascript.

  • the < in </style> gets source.css-ignored-vscode inserted as the top scope
  • the " in the body tag after #aaa gets source.css
  • the < in </script> gets source.js-ignored-vscode

i've a relevant issue on vscode that states this is intentional: microsoft/vscode#187113

i think the best we'll be able to do is style these scopes with the correct teal/green for the syntax in this snippet and see if it breaks anything else.

@backwardspy backwardspy added bug Something isn't working syntax labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working syntax
Projects
None yet
Development

No branches or pull requests

2 participants