editoryInlayHint.foreground/background doesn't apply when extension is enabled

[crd2333]

I'm not sure if I have done something wrong, but it seems the color for inlay hint didn't take effect, in contrast to built-in themes.

Settings for theme Macchiato(one of the setting is useful, though):

Settings for built-in theme:

[sgoudham]

Hey 👋,

Thanks for raising this. I'm running VSCode v1.92.0 with Catppuccin v3.15.0 and I can confirm that I can reproduce this issue.

Interestingly, I'm able to workaround this by targeting the parameter and type options. See below for the config and a screenshot for how it looks.

config

  "catppuccin.customUIColors": {
    "latte": {
      "editorInlayHint.parameterBackground": "red",
      "editorInlayHint.parameterForeground": "crust",
      "editorInlayHint.typeBackground": "pink",
      "editorInlayHint.typeForeground": "crust",
    }
  },

screenshot

I'll need to investigate further to find out why the normal editorInlayHint.foreground and editorInlayHint.background options don't work when the extension is enabled.

[sgoudham]

Hey again 👋,
I've looked into this again and I think I've figured out why.

The Catppuccin theme defines the following keys:

vscode/packages/catppuccin-vsc/src/theme/uiColors.ts

Lines 181 to 186 in 39e26a0

	"editorInlayHint.foreground": palette.surface2,
	"editorInlayHint.background": opacity(palette.mantle, 0.75),
	"editorInlayHint.typeForeground": palette.subtext1,
	"editorInlayHint.typeBackground": opacity(palette.mantle, 0.75),
	"editorInlayHint.parameterForeground": palette.subtext0,
	"editorInlayHint.parameterBackground": opacity(palette.mantle, 0.75),

typeForeground, typeBackground, parameterForeground & parameterBackground are all higher in specificity than just the plain foreground and background. This means that if you want to override the values for Catppuccin, you'll need to override all of the keys. For example:

"catppuccin.customUIColors": {
  "all": {
    "editorInlayHint.foreground": "#000000",
    "editorInlayHint.background": "#ffffff",
    "editorInlayHint.parameterForeground": "#ffffff",
    "editorInlayHint.parameterBackground": "#000000",
    "editorInlayHint.typeForeground": "#ffffff",
    "editorInlayHint.typeBackground": "#000000",
  }
},

I'll be closing this issue now as it's not necessarily a bug. I think it might be worth looking into ways on "unsetting" the key to avoid duplication but I'll raise another issue for to investigate that, should we want that behaviour.