Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if Catppuccin Theme is installed and switch icon pack automatically #10

Open
zzhaolei opened this issue Nov 15, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zzhaolei
Copy link

I use catppuccin mocha.

Goland Dark Theme:
image

Goland Light Theme:
image

Can we have mixed modes? No need to switch icons every time.

@ricardoboss
Copy link

A way to set an icon pack for light and an icon pack for dark mode would be nice. I am using Auto Dark Mode and my IDE switches themes automatically. I'd rather not restart my IDE every time my theme changes.

@quentinguidee
Copy link
Member

Can we have mixed modes? No need to switch icons every time.

I don't think that mixed mode will be implemented one day in the official icons pack. A fork could do that, but I don't think we want to go against the guidelines here + it will be better to spend the efforts for implementing hot-reload.

A way to set an icon pack for light and an icon pack for dark mode would be nice. I am using Auto Dark Mode and my IDE switches themes automatically. I'd rather not restart my IDE every time my theme changes.

For that unfortunately we still need to figure out before how to do dynamic reload. Before that even if we implement theme sync you'll still need to restart.

@sgoudham
Copy link
Contributor

sgoudham commented Aug 7, 2024

I think a mixed-mode will be an absolute last resort for this plugin as we already have the functionality to switch icon packs between the different flavours. As @quentinguidee mentions above, hopefully we can implement some logic that detects if the Catppuccin Theme is installed, automatically switch to the correct icon pack and prompt the user to restart.

I believe you will still need to restart the IDE but probably worth looking at other Icon plugins to see if they have the ability to change the icons dynamically without restarting.

@sgoudham sgoudham changed the title Switching themes, icons are not displayed clearly Detect if Catppuccin Theme is installed and switch icon pack automatically Aug 7, 2024
@sgoudham sgoudham added enhancement New feature or request help wanted Extra attention is needed labels Aug 7, 2024
@huxxcb
Copy link

huxxcb commented Sep 11, 2024

I believe you will still need to restart the IDE but probably worth looking at other Icon plugins to see if they have the ability to change the icons dynamically without restarting.

I know the Atom Material Icons pack supports hot swapping, might be worth a look.

@sgoudham
Copy link
Contributor

I know the Atom Material Icons pack supports hot swapping, might be worth a look.

Yeah that's something that I'm personally aware of but don't have the time to sink into understanding the codebase and their loading strategy as it's a lot more complex than ours. I'd totally appreciate if someone else wants to take a look and list their findings here on how we can adopt hot-reloadable icons or even make a PR for it!

I don't believe @thelooter or @quentinguidee have the time to look at this plugin at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants