Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to version 20.x #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DmitriyStoyanov
Copy link

@DmitriyStoyanov DmitriyStoyanov commented Oct 29, 2024

Update node.js to version 20.x in order to support existing version of lighthouse catchpoint/WebPageTest.agent#671 that currently supported only 18.x or later versions

DmitriyStoyanov and others added 2 commits October 29, 2024 15:08
Update node.js to version 18.x in order to support existing version of lighthouse catchpoint/WebPageTest.agent#671
@DmitriyStoyanov DmitriyStoyanov changed the title Update Node.js to version 18.x Update Node.js to version 20.x Nov 19, 2024
@pmeenan
Copy link
Contributor

pmeenan commented Nov 22, 2024

20 is safe but is it worth jumping straight to 22 which is the current LTS?

@DmitriyStoyanov
Copy link
Author

20 is safe but is it worth jumping straight to 22 which is the current LTS?

I've did it after this comment catchpoint/WebPageTest.agent#672 (comment)
So if it is tested with 20.x version. then we are ok to increase to this version, but who knows, about 22 version. I did testing on my side only with 18.x version and it works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants