Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when creating world + inability to name worlds (experimental 2024-06-xx,tested up to experimental 2024-05-30) #4816

Open
SilearFlare opened this issue Jun 17, 2024 · 7 comments · Fixed by #4918
Labels

Comments

@SilearFlare
Copy link

Describe the bug

Tried downloading the latest experimental (curses, linux, x64) game says 0x9 (tab) is an invalid character and stops me from generating a world. Tested experimental curses linux x64 version from 2024-05-30, the bug does not show up and world can be created safely, so it happened in the last couple weeks.
image

This happens with any kind of world, this is what happens when I get a randomly generated name by just moving forward with worldgen. Throws an 0x9 character error, deletes one character from the world's name, refuses to continue.
If I continue to press tab to continue, it eventually reaches this stage where it actually breaks into the console's prompt for world name (world nam :)
image

Steps To Reproduce

look

Screenshots

No response

Versions and configuration

up

Additional context

No response

@scarf005 scarf005 changed the title Crash when creating world + inability to name worlds (experimental xx/06/24,tested up to experimental30/05/24) Crash when creating world + inability to name worlds (experimental 2024-06-xx,tested up to experimental 2024-05-30) Jun 17, 2024
@fakepass
Copy link

fakepass commented Jul 1, 2024

I have also encountered this bug (also curses, linux, very recent self-compiled game) and did some poking around. It seems the issue here is that the world name prompt, when presented with a character that does something special (in this case, tab) appends that character to the world name in addition to doing whatever it is that character should do. Pressing tab appends a tab character to the world name, then checks whether the world name is valid before trying to finish things and shows you that error message because you're not allowed to put tabs in a world name.

When I rebound world creation to x, it just appended x to the name before asking me whether I was sure.

The function in question is, I believe, worldfactory::show_worldgen_tab_confirm, which I believe calls string_input_popup::query_string to handle input. I cannot truthfully say I understand either function well enough to feel comfortable editing them.

@fakepass
Copy link

fakepass commented Jul 3, 2024

I recompiled the game and can still reproduce the bug.
Screenshot from 2024-07-03 01-13-56

@scarf005 scarf005 reopened this Jul 3, 2024
@scarf005
Copy link
Member

scarf005 commented Jul 3, 2024

could you check whether latest changes are pulled? could you specify the commit the build is based on?

@fakepass
Copy link

fakepass commented Jul 3, 2024

Yes, I have of course pulled the latest changes. I'm on commit 8beb2d5 and this is reflected on the title screen.

@fakepass
Copy link

fakepass commented Jul 3, 2024

Also, the bug doesn't happen if the world name is already the maximum possible length.

@scarf005
Copy link
Member

scarf005 commented Jul 3, 2024

Yes, I have of course pulled the latest changes. I'm on commit 8beb2d5 and this is reflected on the title screen.

i'm sorry, but the screen is borderless and doesn't seem to contain commit hash

@fakepass
Copy link

fakepass commented Jul 3, 2024

Oh, I didn't mean in the screenshot; the commit hash is obscured by the world creation screen there. Here's a new screenshot.
Screenshot from 2024-07-03 03-04-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants