Replace key-encoder lib with equal internal implementation

Author: Comp0te

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "casper-js-sdk",
-  "version": "5.0.0",
+  "version": "5.0.1",
   "license": "Apache 2.0",
   "description": "SDK to interact with the Casper blockchain",
   "homepage": "https://github.com/casper-ecosystem/casper-js-sdk#README.md",
@@ -50,13 +50,12 @@
       "pre-commit": "lint-staged"
     }
   },
-  "overrides": {
-    "elliptic": "6.6.1"
-  },
   "devDependencies": {
     "@jsdevtools/coverage-istanbul-loader": "^3.0.5",
+    "@types/bn.js": "^5.1.6",
     "@types/chai": "^4.1.7",
     "@types/chai-as-promised": "^7.1.5",
+    "@types/elliptic": "^6.4.18",
     "@types/eventsource": "^1.1.15",
     "@types/humanize-duration": "^3.18.1",
     "@types/lodash": "^4.14.191",
@@ -111,6 +110,9 @@
     "webpack-cli": "^4.5.0",
     "webpack-node-externals": "^2.5.2"
   },
+  "overrides": {
+    "elliptic": "6.6.1"
+  },
   "dependencies": {
     "@ethersproject/bignumber": "^5.0.8",
     "@ethersproject/bytes": "^5.0.5",
@@ -123,11 +125,13 @@
     "@scure/bip32": "^1.1.5",
     "@scure/bip39": "^1.2.0",
     "@types/ws": "^8.2.2",
-    "axios": "^1.7.9",
+    "asn1.js": "^5.4.1",
+    "axios": "^1.8.4",
+    "bn.js": "^5.2.1",
+    "elliptic": "6.6.1",
     "eventsource": "^2.0.2",
     "glob": "^7.1.6",
     "humanize-duration": "^3.24.0",
-    "key-encoder": "^2.0.3",
     "lodash": "^4.17.21",
     "node-fetch": "2.6.13",
     "reflect-metadata": "^0.1.13",

package.json

@@ -108,10 +108,12 @@ describe('EraSummary', () => {
     expect(
       jsonRes?.blockHash.toHex(),
       'Block hash does not match expected value'
+      // @ts-ignore IDE issue
     ).to.deep.equal(eraSummaryJson.block_hash);
 
     const allocations = jsonRes!.storedValue!.eraInfo!.seigniorageAllocations;
     const jsonAllocations =
+      // @ts-ignore IDE issue
       eraSummaryJson.stored_value.EraInfo.seigniorage_allocations;
 
     allocations.forEach((summary, index) => {

src/tests/types/EraSummary.test.ts

@@ -32,6 +32,19 @@ describe('PrivateKey', () => {
     ).to.deep.eq(signKeyPair.publicKey.toHex());
   });
 
+  it('should generate correct account from Secp256K1 PEM file', () => {
+    const privateKeyInPem = PrivateKey.fromPem(
+      `-----BEGIN EC PRIVATE KEY-----
+MHQCAQEEIBxq/oiMjAURmCRMhOP/5g7WF33rIKaORGkRoc9wQgRGoAcGBSuBBAAK
+oUQDQgAEe8qaKb3KxL2VXpkwrUlNBAHPQwQeU3unZLV8CdMLp2aGaoLUfprph8Yt
+cs0BmUY0rz+KBwlNMWYL9fR/hoFl8Q==
+-----END EC PRIVATE KEY-----`,
+      KeyAlgorithm.SECP256K1
+    );
+
+    expect(privateKeyInPem.publicKey.toHex()).to.equal('02037bca9a29bdcac4bd955e9930ad494d0401cf43041e537ba764b57c09d30ba766');
+  });
+
   it('should generate PEM file for Ed25519 correctly', () => {
     const naclKeyPair = PrivateKey.generate(KeyAlgorithm.ED25519);
     const publicKeyInPem = naclKeyPair.publicKey.toPem();

src/tests/types/keypair/PrivateKey.test.ts

@@ -2,15 +2,13 @@ import * as secp256k1 from '@noble/secp256k1';
 import { sha256 } from '@noble/hashes/sha256';
 import { hmac } from '@noble/hashes/hmac';
 import { PrivateKeyInternal } from '../PrivateKey';
-import KeyEncoder from 'key-encoder';
 import { Conversions } from '../../Conversions';
 import { readBase64WithPEM } from '../utils';
+import { encodePrivate } from './encoders';
 
 secp256k1.utils.hmacSha256Sync = (k, ...m) =>
   hmac(sha256, k, secp256k1.utils.concatBytes(...m));
 
-export const keyEncoder = new KeyEncoder('secp256k1');
-
 /**
  * Represents a secp256k1 private key, supporting key generation, signing, and PEM encoding.
  * The class offers static methods to create instances from bytes, hex, and PEM formats.
@@ -110,11 +108,7 @@ export class PrivateKey implements PrivateKeyInternal {
    * @returns A PEM-encoded string of the private key.
    */
   toPem(): string {
-    return keyEncoder.encodePrivate(
-      Conversions.encodeBase16(this.key),
-      'raw',
-      'pem'
-    );
+    return encodePrivate(Conversions.encodeBase16(this.key), 'raw', 'pem');
   }
 
   /**
@@ -126,11 +120,7 @@ export class PrivateKey implements PrivateKeyInternal {
   static fromPem(content: string): PrivateKey {
     const privateKeyBytes = readBase64WithPEM(content);
 
-    const rawKeyHex = keyEncoder.encodePrivate(
-      Buffer.from(privateKeyBytes),
-      'der',
-      'raw'
-    );
+    const rawKeyHex = encodePrivate(Buffer.from(privateKeyBytes), 'der', 'raw');
 
     return new PrivateKey(new Uint8Array(Buffer.from(rawKeyHex, 'hex')));
   }

src/types/keypair/secp256k1/PrivateKey.ts

@@ -1,8 +1,8 @@
 import * as secp256k1 from '@noble/secp256k1';
 import { sha256 } from '@noble/hashes/sha256';
-import { keyEncoder } from './PrivateKey';
 import { Conversions } from '../../Conversions';
 import { readBase64WithPEM } from '../utils';
+import { encodePublic } from "./encoders";
 
 /** The expected size of a secp256k1 public key in bytes. */
 const PublicKeySize = 33;
@@ -36,7 +36,7 @@ export class PublicKey {
    * @returns A PEM compliant string containing this instance's public key
    */
   public toPem(): string {
-    return keyEncoder.encodePublic(
+    return encodePublic(
       Conversions.encodeBase16(this.key),
       'raw',
       'pem'
@@ -81,7 +81,7 @@ export class PublicKey {
   static fromPem(content: string): PublicKey {
     const publicKeyBytes = readBase64WithPEM(content);
 
-    const rawKeyHex = keyEncoder.encodePublic(
+    const rawKeyHex = encodePublic(
       Buffer.from(publicKeyBytes),
       'der',
       'raw'